feature: Email Link and Phone Link (in Action Block) #236
Conversation
Deploying head-start with
|
| Latest commit: |
0cad1ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e9d89536.head-start.pages.dev |
| Branch Preview URL: | https://feat-email-and-phone-links.head-start.pages.dev |
| field_type: 'string', | ||
| api_key: 'phone_number', | ||
| hint: 'Best to use international notation: +31 20 2610954', | ||
| validators: { required: {} }, |
There was a problem hiding this comment.
Could add more validation here, but validating phone numbers can be tricky. Editors can also just try if the number the entered, works in the preview.
Even more nice to have would be a Phone Input Field as a DatoCMS plugin. We could create that based on react-phone-number-input. Pinging @velomovies ;)
There was a problem hiding this comment.
I would even go as far as saying this feature can be implemented just by adding a plugin, right? They're all links..
There was a problem hiding this comment.
@MarleenEliza mentioned that my assumption was incorrect, mailto: etc are note valid URLs according to Dato.
| export type Props = HTMLAttributes<'a'> & PhoneLinkProps; | ||
| const { action, phoneNumber, text, ...props } = Astro.props; | ||
|
|
||
| const formatPhoneNumber = (phoneNumber: string) => { |
There was a problem hiding this comment.
This is a bit of a naive formatter. Could pull in the very popular libphonenumber-js package (has zero dependencies) to do the phone number formatting:
jurgenbelien
force-pushed
the
feat/email-and-phone-links
branch
from
eeb8b8f to
7e754d0
Compare
jurgenbelien
force-pushed
the
feat/email-and-phone-links
branch
from
7e754d0 to
0cad1ab
Compare
Important
Depends on #234, which should be merged first.
Changes
Associated issue
N/A
How to test
email-and-phone-linksenvironment and play around with the new Email Link and Phone Link option in Action BlocksChecklist
I have made updated relevant documentation files (in project README, docs/, etc)I have added a decision log entry if the change affects the architecture or changes a significant technology